New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a bug in TensorStridedSliceUpdate
#27803
Fixes a bug in TensorStridedSliceUpdate
#27803
Conversation
@alextp Sorry I had to make an additional small change to pass the backwards compatibility test. This is necessary because I forgot to add the output definition in the op registration before. |
You shouldn't need to make the change to op_history.pbtxt because adding an output is backward-compatible and manual edits to that file are only required for non-backwards-compatible changes. That said it's not harmful. |
Thanks Alex! It's good to know that. The reason I actually did it is because this edit is technically not backwards-compatible as it changes the signature of the |
Adding an output to an op is a backwards-compatible change though as it does not change the behavior of existing graphdefs. |
I see. Shouldn't the backwards compatibility check test take that into account then? Because it was failing until I made that change to |
PiperOrigin-RevId: 243663253
@alextp Fixes a bug introduced in #27327 .