Fix incorrect frame numbers in tf_logging.warn #27871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix tries to address the issue raised in 27848 where the frame numbers in tf_logging.warn is incorrect in python 3. The reason was that in python 2, `warn = warning` but in python 3, an additional wrapper has been added to deprecate the warn. For that reason one additional frame has been added, thus causing incorrect output in the log. This fix fixes 27848. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
ymodak
added
prtype:bugfix
|
@caisq Hi, Could you PTAL and approve. |
caisq
approved these changes
Apr 25, 2019
tensorflow-bot
bot
added
kokoro:force-run
caisq
added
kokoro:force-run
gbaned
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Apr 30, 2019
PiperOrigin-RevId: 245915979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix tries to address the issue raised in #27848 where the frame numbers in tf_logging.warn is incorrect in python 3.
The reason was that in python 2,
warn = warningbut in python 3, an additional wrapper has been added to deprecate the warn. For that reason one additional frame has been added, thus causingincorrect output in the log.
This fix fixes #27848.
Signed-off-by: Yong Tang yong.tang.github@outlook.com