Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TensorFlow follow some of its own deprecation warnings #27964

Merged
merged 3 commits into from Apr 22, 2019
Merged

Make TensorFlow follow some of its own deprecation warnings #27964

merged 3 commits into from Apr 22, 2019

Conversation

girving
Copy link
Contributor

@girving girving commented Apr 18, 2019

TensorFlow should respect the deprecation warnings of TensorFlow.

@rthadur rthadur self-assigned this Apr 18, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Apr 18, 2019
@rthadur rthadur added the size:S CL Change Size: Small label Apr 18, 2019
@rthadur rthadur requested a review from gunan April 18, 2019 22:53
@rthadur rthadur added the comp:ops OPs related issues label Apr 18, 2019
@girving girving changed the title compute_shapes is deprecated. So don't pass it *within* tensorflow itself Make TensorFlow follow some of its own deprecation warnings Apr 18, 2019
@rthadur
Copy link
Contributor

rthadur commented Apr 19, 2019

@girving please resolve conflicts

@girving
Copy link
Contributor Author

girving commented Apr 22, 2019

@rthadur Test failures seem unrelated. What's the right next step?

@rthadur
Copy link
Contributor

rthadur commented Apr 22, 2019

@gunan can you help review this PR, if you are not the correct reviewer , can you please redirect, thank you

@gunan gunan requested review from annarev and removed request for gunan April 22, 2019 17:53
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 22, 2019
annarev
annarev approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@annarev annarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clean up!

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 22, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 22, 2019
@girving
Copy link
Contributor Author

girving commented Apr 22, 2019

@annarev Looks like copybara is failing. Something I need to fix on my end?

@annarev
Copy link
Contributor

annarev commented Apr 22, 2019

I think it might be just waiting for approval (I will approve it soon).

@tensorflow-copybara tensorflow-copybara merged commit 9f052f3 into tensorflow:master Apr 22, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Apr 22, 2019
tensorflow-copybara pushed a commit that referenced this pull request Apr 22, 2019
@tensorflower-gardener
Merge pull request #27964 from girving:shapes
caf18b0 
PiperOrigin-RevId: 244755615
@girving girving deleted the shapes branch April 22, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annarev annarev annarev approved these changes

Assignees

@rthadur rthadur

Labels
cla: yes comp:ops OPs related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@girving @rthadur @annarev @googlebot @kokoro-team @tensorflow-copybara