Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation in tf.keras.layers.Add example #28294

Closed
wants to merge 4 commits into from
Closed

Conversation

ymodak
Copy link
Contributor

@ymodak ymodak commented Apr 30, 2019

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Apr 30, 2019
@rthadur rthadur self-assigned this Apr 30, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Apr 30, 2019
@rthadur rthadur added comp:keras Keras related issues prtype:bugfix PR to fix a bug labels Apr 30, 2019
Copy link
Contributor

@dynamicwebpaige dynamicwebpaige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix. 🙂

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 30, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 30, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 30, 2019
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes May 1, 2019
added = keras.layers.Add()([x1, x2]) # equivalent to added =
keras.layers.add([x1, x2])

added = keras.layers.Add()([x1, x2]) # equivalent to added = keras.layers.add([x1, x2])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting from internal review:

The comment should be moved to above this line to avoid the line-too-long issue.

The code in the comment should be put inside backquotes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes. Thanks!

ymodak added 3 commits May 1, 2019 10:14
I have made the changes. Thanks!
I have made the changes. Thanks!
I have made the changes. Thanks!
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer May 1, 2019
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tensorflow-bot tensorflow-bot bot added the kokoro:force-run Tests on submitted change label May 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 1, 2019
@rthadur rthadur added ready to pull PR ready for merge process kokoro:force-run Tests on submitted change and removed ready to pull PR ready for merge process labels May 1, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 1, 2019
pull bot pushed a commit to testkevinbonz/tensorflow that referenced this pull request May 1, 2019
PR Queue automation moved this from Approved by Reviewer to Closed/Rejected May 2, 2019
@mihaimaruseac mihaimaruseac deleted the ymodak-patch-1 branch May 2, 2019 14:55
@mihaimaruseac
Copy link
Collaborator

Merged in ac6e979

@ymodak
Copy link
Contributor Author

ymodak commented May 2, 2019

@mihaimaruseac Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:keras Keras related issues prtype:bugfix PR to fix a bug ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Closed/Rejected
Development

Successfully merging this pull request may close these issues.

[doc/keras] incorrect comment in the example for tf.keras.layers.Add
6 participants