-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rocprim version #28771
Merged
tensorflow-copybara
merged 1 commit into
tensorflow:master
from
ROCm:google-upstream-pr-update-rocprim
May 17, 2019
Merged
Bump rocprim version #28771
tensorflow-copybara
merged 1 commit into
tensorflow:master
from
ROCm:google-upstream-pr-update-rocprim
May 17, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whchung
approved these changes
May 16, 2019
tensorflow-bot
bot
added
kokoro:force-run
Tests on submitted change
ready to pull
PR ready for merge process
labels
May 16, 2019
chsigg
approved these changes
May 17, 2019
tensorflow-bot
bot
added
kokoro:force-run
Tests on submitted change
ready to pull
PR ready for merge process
labels
May 17, 2019
errors in test targets are stemmed from XLA CPU logic and has nothing to do with this PR. suggest continue to merge it. |
The XLA CPU issue should be fixed now.
…On Fri, May 17, 2019, 17:13 Wen-Heng (Jack) Chung ***@***.***> wrote:
errors in test targets are stemmed from XLA CPU logic and has nothing to
do with this PR. suggest continue to merge it.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#28771?email_source=notifications&email_token=ABZM5DVTHARDKWOIK7AV7WTPV3DSTA5CNFSM4HNN4PO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVVAQCQ#issuecomment-493488138>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZM5DSH4URUWIVSZHKNX2LPV3DSTANCNFSM4HNN4POQ>
.
|
pull bot
pushed a commit
to Rachelmorrell/tensorflow
that referenced
this pull request
May 17, 2019
…upstream-pr-update-rocprim PiperOrigin-RevId: 248776835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current rocprim is out-of-date and introduces linker error at compilation times. Updating to new version of rocprim that fix the linker error.
@whchung