Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rocprim version #28771

Merged

Conversation

jerryyin
Copy link
Member

@jerryyin jerryyin commented May 16, 2019

The current rocprim is out-of-date and introduces linker error at compilation times. Updating to new version of rocprim that fix the linker error.

@whchung

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label May 16, 2019
@whchung whchung self-requested a review May 16, 2019 17:15
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 16, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 16, 2019
@rthadur rthadur requested a review from chsigg May 16, 2019 17:42
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation May 16, 2019
@rthadur rthadur removed the ready to pull PR ready for merge process label May 16, 2019
@rthadur rthadur self-assigned this May 16, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer May 17, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 17, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 17, 2019
@whchung
Copy link
Contributor

whchung commented May 17, 2019

errors in test targets are stemmed from XLA CPU logic and has nothing to do with this PR. suggest continue to merge it.

@chsigg
Copy link
Contributor

chsigg commented May 17, 2019 via email

@whchung whchung added the kokoro:force-run Tests on submitted change label May 17, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 17, 2019
pull bot pushed a commit to Rachelmorrell/tensorflow that referenced this pull request May 17, 2019
…upstream-pr-update-rocprim

PiperOrigin-RevId: 248776835
@tensorflow-copybara tensorflow-copybara merged commit bfb8a59 into tensorflow:master May 17, 2019
PR Queue automation moved this from Approved by Reviewer to Merged May 17, 2019
@jerryyin jerryyin deleted the google-upstream-pr-update-rocprim branch December 20, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants