Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 more cherrypicks #28965

Merged
merged 3 commits into from
May 23, 2019
Merged

3 more cherrypicks #28965

merged 3 commits into from
May 23, 2019

Conversation

bananabowl
Copy link
Contributor

No description provided.

er91 and others added 3 commits May 23, 2019 07:43
…erialized.

Renaming this op is fine because it's only a transient op occurring in GraphOptimizationPass and it's never serialized in GraphDef.

PiperOrigin-RevId: 249517076
…onsistently, and update the documentation to be consistent as well.

Currently, in practice it is `None` (due to the way VariableMetaclass is used), but in some APIs, it is listed as `True` which can be a source of confusion and appears in the generated documentation. In practice, this should have no effect other than fixing documentation.
Added a test to illustrate the behavior, but the test passes with and without the changes here.

PiperOrigin-RevId: 249559719
…d satisfy grappler by removing the initializer_name of the reference variables.

PiperOrigin-RevId: 249580046
@tensorflow-bot tensorflow-bot bot added the size:L CL Change Size: Large label May 23, 2019
@bananabowl bananabowl added the kokoro:force-run Tests on submitted change label May 23, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 23, 2019
@bananabowl bananabowl requested a review from alextp May 23, 2019 14:48
@bananabowl bananabowl merged commit 758880a into tensorflow:r1.14 May 23, 2019
@bananabowl bananabowl deleted the cherrypicks_XFZ0N branch May 23, 2019 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:L CL Change Size: Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants