[ROCm] Add ROCm support for crop_and_resize_op #29150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryyin
changed the title
whchung
approved these changes
May 30, 2019
tensorflow-bot
bot
added
kokoro:force-run
chsigg
approved these changes
Jun 4, 2019
|
|
||
| #if GOOGLE_CUDA |
There was a problem hiding this comment.
Maybe we should put these lines in a shared place. If it's not too much trouble, and in a separate PR.
There was a problem hiding this comment.
I looked around a little bit for this. It looks like ScopedActivateExecutorContext in either cuda::ScopedActivateExecutorContext, or rocm::ScopedActivateExecutorContext, are just alias to gpu::ScopedActivateExecutorContext. Is it easier to just move the corresponding using stream_executor::*::ScopedActivateExecutorContext to either rocm_activation.h or cuda_activation.h?
tensorflow-copybara
pushed a commit
that referenced
this pull request
Jun 5, 2019
…r-crop_and_resize_op PiperOrigin-RevId: 251543853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ROCm support for crop_and_resize_op
The changes in this PR are trivial, please review and merge...thanks.
test preformed: //tensorflow/core/kernels:crop_and_resize_op_test
@tatianashp @whchung