[ROCm] Add ROCm support for 2D and 3D convolution ops. #29185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chsigg
reviewed
Jun 3, 2019
whchung
force-pushed
the
google_upstream_conv_ops
branch
from
1cedf52
to
30b9947
Compare
whchung
force-pushed
the
google_upstream_conv_ops
branch
from
30b9947
to
ec828f9
Compare
|
looking at the log I don't believe those failures are relevant to changes proposed in this PR. |
chsigg
reviewed
Jun 12, 2019
whchung
force-pushed
the
google_upstream_conv_ops
branch
from
8a816a0
to
51dae56
Compare
|
looking at the log I don't believe those failures are relevant to changes proposed in this PR. |
|
@chsigg a gentle ping. |
MIOpen has its own algorithm find logic and would return the size of scratch memory required to client applications. Modify AlgorithmConfig to track such information.
whchung
force-pushed
the
google_upstream_conv_ops
branch
from
51dae56
to
11864b1
Compare
|
@chsigg a gentle ping for this particular PR. |
|
Again looking at the log I don't believe those failures are relevant to changes proposed in this PR. |
chsigg
approved these changes
Jun 27, 2019
tensorflow-bot
bot
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Jun 28, 2019
…onv_ops PiperOrigin-RevId: 255465733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIOpen has its own algorithm find logic and would return the size of scratch
memory required to client applications. Modify AlgorithmConfig to track such
information.
This is a follow-up PR for #29172 .