Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.14-rc1 cherry-pick request: NCCL broadcast bug #29231

Merged
merged 2 commits into from May 31, 2019

Conversation

dubey
Copy link
Member

@dubey dubey commented May 31, 2019

Without this cherry-pick, NCCL broadcast does not work.

Requested by NVIDIA. FYI @nluehr

@dubey dubey requested review from azaks2 and chsigg as code owners May 31, 2019 21:03
@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label May 31, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@dubey dubey requested review from bananabowl and removed request for chsigg and azaks2 May 31, 2019 21:03
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: no label May 31, 2019
@bananabowl bananabowl merged commit a8c0738 into tensorflow:r1.14 May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:S CL Change Size: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants