Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add allow_pickle for reuters #29440

Merged
merged 1 commit into from Jul 18, 2019
Merged

add allow_pickle for reuters #29440

merged 1 commit into from Jul 18, 2019

Conversation

skeydan
Copy link

@skeydan skeydan commented Jun 5, 2019 •
edited

Starting with numpy 1.16.3 the default of allow_picke in np.load has changed from True to False.

This means that all occurrences of

with np.load(path) as f:

in Keras datasets need to be changed to

with np.load(path, allow_pickle=True) as f:

otherwise we get

ValueError: Object arrays cannot be loaded when allow_pickle=False

See also https://github.com/tensorflow/tensorflow/commit /79a8d5cdad942b9853aa70b59441983b42a8aeb3 which did this for imdb.
This PR does this for reuters.

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Jun 5, 2019
@skeydan skeydan mentioned this pull request Jun 5, 2019
Closed
@rthadur rthadur self-assigned this Jun 5, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jun 5, 2019
@rthadur rthadur requested a review from pavithrasv June 18, 2019 21:10
@rthadur rthadur added the comp:keras Keras related issues label Jun 18, 2019
@skeydan
Copy link
Author

skeydan commented Jul 15, 2019

Hi, any news on this? Thanks!

@skeydan skeydan mentioned this pull request Jul 15, 2019
Closed
@rthadur
Copy link
Contributor

rthadur commented Jul 15, 2019 •
edited

@skeydan thank you for your contribution , can you please add some description to the PR why the change is required ?

@skeydan
Copy link
Author

skeydan commented Jul 16, 2019

Sorry - description updated :-)

pavithrasv
pavithrasv approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@pavithrasv pavithrasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 16, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 16, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 16, 2019
@skeydan
Copy link
Author

skeydan commented Jul 16, 2019

you're welcome :-)

@tensorflow-copybara tensorflow-copybara merged commit 4f3262d into tensorflow:master Jul 18, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Jul 18, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jul 18, 2019
@tensorflower-gardener
Merge pull request #29440 from skeydan:fix-load-dataset-reuters
4bc6573 
PiperOrigin-RevId: 258824855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavithrasv pavithrasv pavithrasv approved these changes

Assignees

@rthadur rthadur

Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@skeydan @rthadur @pavithrasv @googlebot @kokoro-team @tensorflow-copybara