Added examples to tf.clip_by_value #29774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextp
suggested changes
Jun 14, 2019
tensorflow/python/ops/clip_ops.py
Outdated
| For example: | ||
|
|
||
| ```python | ||
| A=tf.constant([[1,20,13],[3,21,13]]) |
There was a problem hiding this comment.
Can the code be updated to be compatible with TF style? This means space around = used for assignment, space after commas, etc
tensorflow/python/ops/clip_ops.py
Outdated
| A=tf.constant([[1,20,13],[3,21,13]]) | ||
| B=tf.clip_by_value(A, clip_value_min=0, clip_value_max=3) #[[1, 3, 3],[3, 3, 3]] | ||
| C=tf.clip_by_value(A, clip_value_min=0., clip_value_max=3.) | ||
| # throws `TypeError` as input and clip_values are of different dtype |
There was a problem hiding this comment.
The comment on a different line is not obvious; either put it before or just elide this altogether
There was a problem hiding this comment.
Thanks @alextp. Updated according to your suggestion.
tensorflow/python/ops/clip_ops.py
Outdated
| B=tf.clip_by_value(A, clip_value_min=0, clip_value_max=3) #[[1, 3, 3],[3, 3, 3]] | ||
| C=tf.clip_by_value(A, clip_value_min=0., clip_value_max=3.) | ||
| # throws `TypeError` as input and clip_values are of different dtype | ||
| D=tf.constant([2.0,3.1,5.3]) |
There was a problem hiding this comment.
I don't know what value this third example is adding
There was a problem hiding this comment.
Removed third example. Thanks!
alextp
previously approved these changes
Jun 14, 2019
tensorflow-bot
bot
added
kokoro:force-run
|
@jvishnuvardhan Can you please check Ubuntu Sanity errors? Thanks! |
alextp
previously approved these changes
Jun 20, 2019
Updated to clear sanity checks
alextp
approved these changes
Jun 24, 2019
pull bot
pushed a commit
to Cache-Cloud/tensorflow
that referenced
this pull request
Jun 25, 2019
…tch-8 PiperOrigin-RevId: 254979441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.