Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide hwloc symbols in libtensorflow_framework.so #29807

Merged
merged 1 commit into from Jun 14, 2019

Conversation

alsrgv
Copy link
Contributor

@alsrgv alsrgv commented Jun 14, 2019

Currently, hwloc_* symbols are being exported by libtensorflow_framework.so, which could conflict with hwloc_* symbols used by MPI.

Fixes horovod/horovod#1123
cc @gunan @byronyi

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Jun 14, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 14, 2019
@rthadur rthadur self-assigned this Jun 14, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jun 14, 2019
@tensorflow-copybara tensorflow-copybara merged commit 83950c3 into tensorflow:master Jun 14, 2019
PR Queue automation moved this from Assigned Reviewer to Merged Jun 14, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jun 14, 2019
@alsrgv alsrgv deleted the hide_hwloc_symbols branch June 14, 2019 23:34
@alsrgv
Copy link
Contributor Author

alsrgv commented Jun 14, 2019

@gunan, can this be cherry-picked into r1.14? 🙄

@byronyi
Copy link
Contributor

byronyi commented Jun 15, 2019

Ping @bananabowl; hope it is not too late.

@mihaimaruseac
Copy link
Collaborator

This will get into 1.14.1, which will be released soon. We don't yet have a timeline, but I wanted to update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

TF 1.14 crashes with hwloc
8 participants