lite: change usage of 'fileno' to allow for msvc implementation #29893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattn
reviewed
Jun 20, 2019
mattn
reviewed
Jun 22, 2019
miaout17
approved these changes
Jun 28, 2019
tensorflow-bot
bot
added
kokoro:force-run
mattn
reviewed
Jun 28, 2019
| if (fstat(fileno(file.get()), &sb) != 0) { | ||
|
|
||
| // support usage of msvc's posix-like fileno symbol | ||
| #ifdef _WIN32 |
rthadur
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very straightforward change, just guarding the usage of
filenoto sub it with_filenowhere needed.In this case there shouldn't be an instance where the differences in the MSVC definition which fall outside of the POSIX version will matter. See https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/fileno?view=vs-2019 for the specific differences, but it is quite common for libraries to utilize this workaround (see: gtest).
Also yes, you really can build TFLite on Windows if you're brave enough.