Fix funcdef lookup in auto_mixed_precision grappler pass #30140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Non-inlined funcdefs only exist in the graph's function registry instead of the global op registry. Such ops (e.g., tf.nn.swish) previously caused the auto_mixed_precision grappler pass to fail. - This commit also adds a test for such cases.
reedwm
approved these changes
Jun 25, 2019
tensorflow-bot
bot
added
kokoro:force-run
pull bot
pushed a commit
to Pandinosaurus/tensorflow
that referenced
this pull request
Jul 1, 2019
PiperOrigin-RevId: 256003197
|
@benbarsdell Will auto_mixed_precision do the automatic loss scaling? We only need to set auto_mixed_precision=True in ConfigProto? |
|
Loss scaling is not implemented within the grappler graph optimizer. Setting You can enable both loss scaling and the graph optimizer by wrapping your optimizer in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-inlined funcdefs only exist in the graph's function registry instead of the global op registry. Such ops (e.g., tf.nn.swish) previously caused the auto_mixed_precision grappler pass to fail.
This commit also adds a test for such cases.
attn @reedwm
cc @nluehr