Fix KeyError when validation_data was given as a dict #30258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix tries to address the issue raised in 30122 where a KeyError was thrown when validation_data was given as a dict during the mode.fit. This fix fixes the issue. Thisfix fixes 30122. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
qlzh727
reviewed
Jul 8, 2019
| @@ -207,7 +207,8 @@ def model_iteration(model, | |||
| val_samples_or_steps = validation_steps | |||
| else: | |||
| # Get num samples for printing. | |||
| val_samples_or_steps = val_inputs and val_inputs[0].shape[0] or None | |||
| vals = val_inputs.values() if isinstance(val_inputs, dict) else val_inputs | |||
| val_samples_or_steps = vals and vals[0].shape[0] or None | |||
There was a problem hiding this comment.
probably skip the dict check and use nest.flatten(vals)[0].shape[0] here.
There was a problem hiding this comment.
Thanks @qlzh727, the PR has been updated.
qlzh727
requested changes
Jul 8, 2019
| @@ -110,6 +110,43 @@ def test_print_info_with_numpy(self, do_validation): | |||
| if do_validation: | |||
| self.assertIn(", validate on 50 samples", mock_stdout.getvalue()) | |||
|
|
|||
| def test_dict_input(self): | |||
There was a problem hiding this comment.
Should be test_dict_validation_input()
| model = my_model() | ||
| model.compile(loss="mae", optimizer="adam") | ||
|
|
||
| mock_stdout = six.StringIO() |
There was a problem hiding this comment.
I don't see the reason to mock the output, are u trying to validate any output here?
There was a problem hiding this comment.
Thanks for the comment. Removed.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
Thanks @qlzh727 for the review. The PR has been updated. Please take a look and let me know if there are any other issues. |
|
Ping @qlzh727, any chance to take a look at the PR? |
qlzh727
approved these changes
Jul 22, 2019
tensorflow-bot
bot
added
kokoro:force-run
tensorflow-copybara
pushed a commit
that referenced
this pull request
Jul 25, 2019
PiperOrigin-RevId: 260005639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix tries to address the issue raised in #30122 where a KeyError was thrown when validation_data was given as a dict during the mode.fit. This fix fixes the issue.
This fix fixes #30122.
Signed-off-by: Yong Tang yong.tang.github@outlook.com