Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] ROCm stream executor implementation updates #30299

Merged
merged 3 commits into from Jul 11, 2019
Merged

[ROCm] ROCm stream executor implementation updates #30299

merged 3 commits into from Jul 11, 2019

Conversation

deven-amd
Copy link
Contributor

This PR pushes out updates in the ROCm stream executor implementation from the ROCm TF fork. Most of the changes are cosmetic (clang-format related). The lone functional change is the addition of conv 3D support.

Please review and merge. thanks.

@tatianashp @whchung @chsigg

@tensorflow-bot tensorflow-bot bot added the size:L CL Change Size: Large label Jul 2, 2019
@gbaned gbaned self-assigned this Jul 2, 2019
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 2, 2019
@gbaned gbaned requested a review from chsigg July 2, 2019 04:26
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 2, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 2, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 2, 2019
@gbaned gbaned added the comp:gpu GPU related issues label Jul 3, 2019
@deven-amd
Copy link
Contributor Author

@rthadur

this is the 2nd of 4 PRs that seem to be stuck in the merge pipeline.
Please let me know if there is anything that needs to be done on my end.
thanks

deven

@rthadur
Copy link
Contributor

rthadur commented Jul 10, 2019

@rthadur

this is the 2nd of 4 PRs that seem to be stuck in the merge pipeline.
Please let me know if there is anything that needs to be done on my end.
thanks

deven

@deven-amd thank you for your patience waiting for @chsigg review in order to pull this in.

@rthadur rthadur removed the ready to pull PR ready for merge process label Jul 10, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 11, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 11, 2019
@tensorflow-copybara tensorflow-copybara merged commit 1e24623 into tensorflow:master Jul 11, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Jul 11, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jul 11, 2019
@tensorflower-gardener
Merge pull request #30299 from ROCmSoftwarePlatform:google_upstream_r…
3d848eb 
…ocm_stream_executor_updates_190701

PiperOrigin-RevId: 257617613
@deven-amd deven-amd deleted the google_upstream_rocm_stream_executor_updates_190701 branch August 2, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whchung whchung whchung approved these changes

@chsigg chsigg chsigg approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:gpu GPU related issues ready to pull PR ready for merge process size:L CL Change Size: Large
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@deven-amd @rthadur @whchung @chsigg @googlebot @kokoro-team @tensorflow-copybara @gbaned