Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Skipping subtests that check support for int8x4 type (on the GPU) #30505

Conversation

deven-amd
Copy link
Contributor

ROCm platform currently does not support int8x4 type (on the GPU)

This commit skips subtests (within python unit-tests) that test this functionality. The "skip" is guarded by the call to "is_built_with_rocm()", and hence these unit-tests will not be affected in any way when running with TF which was not built with ROCm support (i.e. --config=rocm)


@tatianashp @whchung @chsigg

ROCm platform currently does not support int8x4 type (on the GPU)

This commit skips subtests (within python unit-tests) that test this functionality. The "skip" is guarded by the call to "is_built_with_rocm()", and hence these unit-tests will not be affected in any way when running with TF which was not built with ROCm support (i.e. `--config=rocm`)
@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Jul 8, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 8, 2019
@whchung whchung requested a review from chsigg July 8, 2019 20:48
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 8, 2019
@rthadur rthadur self-assigned this Jul 9, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jul 9, 2019
@rthadur rthadur added comp:gpu GPU related issues and removed ready to pull PR ready for merge process labels Jul 9, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 9, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 9, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 9, 2019
@tensorflow-copybara tensorflow-copybara merged commit 965dbc9 into tensorflow:master Jul 9, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Jul 9, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jul 9, 2019
…kip_int8x4_type_subtests

PiperOrigin-RevId: 257233462
@deven-amd deven-amd deleted the google_upstream_skip_int8x4_type_subtests branch August 2, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:gpu GPU related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants