Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linking error of CoreFoundation for iOS #30519

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Fix linking error of CoreFoundation for iOS #30519

merged 1 commit into from
Jul 12, 2019
+1 −3

Conversation

jekyll88
Copy link
Contributor

@jekyll88 jekyll88 commented Jul 9, 2019

It appears linking error while building iOS package for arm64 only.
tensorflow/contrib/makefile/build_all_ios.sh -a arm64

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Jul 9, 2019
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 9, 2019
@gbaned gbaned self-assigned this Jul 9, 2019
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 9, 2019
@jekyll88 jekyll88 mentioned this pull request Jul 10, 2019
Merged
@mihaimaruseac
Copy link
Collaborator

Can you rebase this on current master? Somehow this doesn't seem to see the changes in #30279 but GitHub doesn't report any conflict.

@mihaimaruseac mihaimaruseac self-requested a review July 10, 2019 16:33
@jekyll88
Fix linking error of CoreFoundation for iOS
f9a3098 
It appears linking error while building iOS package for arm64 only.
tensorflow/contrib/makefile/build_all_ios.sh -a arm64
@jekyll88
Copy link
Contributor Author

Can you rebase this on current master? Somehow this doesn't seem to see the changes in #30279 but GitHub doesn't report any conflict.

Done. Could you check it again?

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 11, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 11, 2019
@mihaimaruseac
Copy link
Collaborator

Thank you

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 11, 2019
@tensorflow-copybara tensorflow-copybara merged commit f9a3098 into tensorflow:master Jul 12, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Jul 12, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jul 12, 2019
@tensorflower-gardener
Merge pull request #30519 from jekyll88:master
8783806 
PiperOrigin-RevId: 257794712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@petewarden petewarden Awaiting requested review from petewarden

@wolffg wolffg Awaiting requested review from wolffg

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jekyll88 @googlebot @mihaimaruseac @kokoro-team @tensorflow-copybara @gbaned