Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTEL MKL] Added support for common utility functions for MKL-DNN v1.0. #30547

Merged
merged 7 commits into from Jul 23, 2019
Merged

[INTEL MKL] Added support for common utility functions for MKL-DNN v1.0. #30547

merged 7 commits into from Jul 23, 2019

Conversation

bhavani-subramanian
Copy link
Contributor

No description provided.

@tensorflow-bot tensorflow-bot bot added the size:L CL Change Size: Large label Jul 9, 2019
@rthadur rthadur self-assigned this Jul 9, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jul 9, 2019
@rthadur rthadur added the comp:mkl MKL related issues label Jul 9, 2019
@rthadur rthadur requested a review from penpornk July 9, 2019 22:19
penpornk
penpornk requested changes Jul 10, 2019
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
How long will you support MKL-DNN v0.x in TensorFlow? Will the code be removed eventually?

tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Jul 10, 2019
@bhavani-subramanian
Copy link
Contributor Author

@penpornk Thanks for reviewing the PR! I have addressed your review comments. Please let me know if it looks okay.

@rthadur rthadur requested a review from penpornk July 15, 2019 19:51
penpornk
penpornk requested changes Jul 17, 2019
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you very much! :)

tensorflow/core/util/mkl_util.h Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
@rthadur rthadur added the stat:awaiting response Status - Awaiting response from author label Jul 18, 2019
@bhavani-subramanian
Copy link
Contributor Author

@penpornk I have addressed your review comments. Please take a look. Thanks!

@rthadur rthadur requested a review from penpornk July 19, 2019 17:23
@rthadur rthadur added awaiting review Pull request awaiting review and removed stat:awaiting response Status - Awaiting response from author labels Jul 19, 2019
penpornk
penpornk approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience! :)

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 19, 2019
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jul 19, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 19, 2019
penpornk
penpornk requested changes Jul 19, 2019
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes, please.

tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
tensorflow/core/util/mkl_util.h Outdated Show resolved Hide resolved
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Jul 19, 2019
@penpornk penpornk removed the awaiting review Pull request awaiting review label Jul 19, 2019
@bhavani-subramanian
Copy link
Contributor Author

@penpornk I have changed CHECK_NE to DCHECK_NE.

penpornk
penpornk approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@tensorflow-bot tensorflow-bot bot added the kokoro:force-run Tests on submitted change label Jul 19, 2019
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jul 19, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 19, 2019
@penpornk penpornk added the kokoro:force-run Tests on submitted change label Jul 22, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 22, 2019
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jul 22, 2019
@tensorflow-copybara tensorflow-copybara merged commit 5556dd6 into tensorflow:master Jul 23, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Jul 23, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jul 23, 2019
@tensorflower-gardener
Merge pull request #30547 from Intel-tensorflow:mkldnn-1.0-utils
3aac651 
PiperOrigin-RevId: 259442125
@nammbash nammbash deleted the mkldnn-1.0-utils branch June 16, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penpornk penpornk penpornk approved these changes

Assignees

@rthadur rthadur

Labels
cla: yes comp:mkl MKL related issues ready to pull PR ready for merge process size:L CL Change Size: Large
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bhavani-subramanian @penpornk @googlebot @kokoro-team @tensorflow-copybara @rthadur