Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTEL MKL] Fixed quantized matmul unit test. #30570

Merged
merged 1 commit into from Jul 11, 2019
Merged

[INTEL MKL] Fixed quantized matmul unit test. #30570

merged 1 commit into from Jul 11, 2019

Conversation

mdfaijul
Copy link
Contributor

The test has been failing due to subtle mismatch in the computation between the kernels and unit test. This PR fixes it.

@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Jul 10, 2019
@rthadur rthadur self-assigned this Jul 10, 2019
@rthadur rthadur requested a review from penpornk July 10, 2019 20:02
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jul 10, 2019
@rthadur rthadur added the comp:mkl MKL related issues label Jul 10, 2019
penpornk
penpornk approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 10, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 10, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 10, 2019
@tensorflow-copybara tensorflow-copybara merged commit 3ccb04a into tensorflow:master Jul 11, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Jul 11, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jul 11, 2019
@tensorflower-gardener
Merge pull request #30570 from Intel-tensorflow:amin/qmatmul-ut-fix
2daa2de 
PiperOrigin-RevId: 257665916
@mdfaijul mdfaijul deleted the amin/qmatmul-ut-fix branch February 18, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penpornk penpornk penpornk approved these changes

Assignees

@rthadur rthadur

Labels
cla: yes comp:mkl MKL related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mdfaijul @penpornk @googlebot @kokoro-team @tensorflow-copybara @rthadur