Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to build files for patch release #30583

Merged
merged 3 commits into from
Jul 11, 2019
Merged

Changes to build files for patch release #30583

merged 3 commits into from
Jul 11, 2019

Conversation

mihaimaruseac
Copy link
Collaborator

Add set -ex to build scripts as well as bazel flags for incompatible versions.

Also change Dockerfile for Debian-based docker container

@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Jul 11, 2019
@yifeif yifeif merged commit 0673265 into r1.13 Jul 11, 2019
@mihaimaruseac mihaimaruseac deleted the patch-set-ex-to-build-files branch July 11, 2019 01:13
@mihaimaruseac mihaimaruseac mentioned this pull request Jul 12, 2019
Merged
mihaimaruseac added a commit that referenced this pull request Jul 12, 2019
@mihaimaruseac
Add one more flag for Bazel compatibility.
c8df26c 
This also adds the 3 compatibility flags on windows builds, as I missed
doing that in #30583
@mihaimaruseac mihaimaruseac mentioned this pull request Jul 12, 2019
Merged
gunan pushed a commit that referenced this pull request Jul 12, 2019
@mihaimaruseac @gunan
Add one more flag for Bazel compatibility.
d38ba6b 
This also adds the 3 compatibility flags on windows builds, as I missed
doing that in #30583
mihaimaruseac added a commit that referenced this pull request Jul 13, 2019
@mihaimaruseac
Remove additional bazel flags in pip_smoke_test
6e4963f 
pip_smoke_test only does `bazel cquery` so it doesn't need the build
flags I added in the past few commits (#30651, #30583).

This should now fix sanity build.
@mihaimaruseac mihaimaruseac mentioned this pull request Jul 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yifeif yifeif yifeif approved these changes

@gunan gunan Awaiting requested review from gunan

Assignees

@yifeif yifeif

@gunan gunan

Labels
cla: yes size:S CL Change Size: Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mihaimaruseac @yifeif @googlebot @gunan