Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Re-enabling ROCm support for the average pooling op #30613

Conversation

deven-amd
Copy link
Contributor

ROCm support for the average pooling op was disabled in this commit (151ebd0) , because it was leading to a compiler error in the --config=rocm build.

That issue has now been fixed and hence filign this PR to re-enable ROCm support for the average pooling op.

please review and merge. thanks.


@tatianashp @whchung @chsigg

ROCm support for the average pooling op was disabled in PR #, because it was leading to a compiler error in the `--config=rocm` build. That issue has now been fixed and hence filign this PR to re-enable ROCm support for the average pooling op.
@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Jul 11, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 11, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 11, 2019
@gbaned gbaned self-assigned this Jul 12, 2019
@gbaned gbaned added the comp:gpu GPU related issues label Jul 12, 2019
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 12, 2019
@gbaned gbaned requested a review from chsigg July 12, 2019 03:49
@tensorflow-bot tensorflow-bot bot added the kokoro:force-run Tests on submitted change label Jul 16, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 16, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 16, 2019
@tensorflow-copybara tensorflow-copybara merged commit f021805 into tensorflow:master Jul 16, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Jul 16, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jul 16, 2019
…vgpooling_op_part_two

PiperOrigin-RevId: 258349112
@deven-amd deven-amd deleted the google_upstream_avgpooling_op_part_two branch August 2, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:gpu GPU related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants