Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlir] enable Affine Dialect in tf-opt #30654

Merged
merged 1 commit into from
Jul 12, 2019
Merged

[mlir] enable Affine Dialect in tf-opt #30654

merged 1 commit into from
Jul 12, 2019

Conversation

freedomtan
Copy link
Contributor

tf-opt --help shows Affine dialect passes, but it doesn't
recognize the Affine dialect because AffineDialectRegistration
is not linked in.

@freedomtan
[mlir] enable Affine Dialect in tf-opt
7c3f2d5 
`tf-opt --help` shows Affine dialect passes, but it doesn't
recognize the Affine dialect because AffineDialectRegistration
is not linked in.
@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Jul 12, 2019
@rthadur rthadur self-assigned this Jul 12, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jul 12, 2019
@rthadur rthadur added the comp:gpu GPU related issues label Jul 12, 2019
@rthadur rthadur requested a review from jpienaar July 12, 2019 16:55
jpienaar
jpienaar approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@jpienaar jpienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes we've been using the mlir-opt for tests using affine dialect/transformations and piping along with tf-opt. But this looks good too.

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 12, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 12, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 12, 2019
@tensorflow-copybara tensorflow-copybara merged commit 7c3f2d5 into tensorflow:master Jul 12, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Jul 12, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jul 12, 2019
@tensorflower-gardener
Merge pull request #30654 from freedomtan:add_affine_dialect_to_tf_opt
ec64a3e 
PiperOrigin-RevId: 257834228
@freedomtan
Copy link
Contributor Author

Thanks. Yes, I know mlir-opt works, but as I said tf-opt --help shows Affine passes. That was a bit confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpienaar jpienaar jpienaar approved these changes

Assignees

@rthadur rthadur

Labels
cla: yes comp:gpu GPU related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@freedomtan @jpienaar @googlebot @kokoro-team @tensorflow-copybara @rthadur