Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for unit test failure #30890

Merged
merged 1 commit into from Jul 23, 2019
Merged

Fix for unit test failure #30890

merged 1 commit into from Jul 23, 2019

Conversation

jojivk73
Copy link
Contributor

@jojivk73 jojivk73 commented Jul 19, 2019 •
edited

[INTEL MKL] Fix for failing unit testcase in : //tensorflow/core:graph_mkl_layout_pass.
It was failing due to wrong output check. The testcase was added for FusedBatchNormV3 support with Intel MKL DN PR: #30386

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Jul 19, 2019
@rthadur rthadur self-assigned this Jul 19, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jul 19, 2019
@rthadur rthadur added the comp:mkl MKL related issues label Jul 19, 2019
@rthadur rthadur requested a review from penpornk July 19, 2019 23:13
@rthadur
Copy link
Contributor

rthadur commented Jul 19, 2019

@jojivk73 thank you for your contribution , can you please update description with relevant information.

@jojivk73
Copy link
Contributor Author

jojivk73 commented Jul 22, 2019 •
edited

-Done

penpornk
penpornk approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 22, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 22, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 22, 2019
@tensorflow-copybara tensorflow-copybara merged commit 1094e3e into tensorflow:master Jul 23, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Jul 23, 2019
tensorflow-copybara pushed a commit that referenced this pull request Jul 23, 2019
@tensorflower-gardener
Merge pull request #30890 from Intel-tensorflow:utfixes
80465fc 
PiperOrigin-RevId: 259438860
@nammbash nammbash deleted the utfixes branch June 16, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penpornk penpornk penpornk approved these changes

Assignees

@rthadur rthadur

Labels
cla: yes comp:mkl MKL related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jojivk73 @rthadur @penpornk @googlebot @kokoro-team @tensorflow-copybara