Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy missing header files #31059

Merged
merged 2 commits into from Aug 3, 2019
Merged

Conversation

d02k01
Copy link
Contributor

@d02k01 d02k01 commented Jul 26, 2019

In pre-built TensorFlow packages for Windows systems, some header files are missing. These are needed for include/tensorflow/c/c_api.h.

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Jul 26, 2019
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@d02k01
Copy link
Contributor Author

d02k01 commented Jul 26, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gbaned gbaned self-assigned this Jul 26, 2019
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 26, 2019
@gbaned gbaned requested a review from gunan July 26, 2019 09:02
gunan
gunan previously approved these changes Jul 26, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 26, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 26, 2019
@gunan
Copy link
Contributor

gunan commented Jul 26, 2019

@sjamesr we may want to do this for all the other header files you added.

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 26, 2019
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Jul 27, 2019
@d02k01 d02k01 changed the title Copy tf_attrtype.h Copy missing header files Jul 27, 2019
@d02k01
Copy link
Contributor Author

d02k01 commented Jul 27, 2019

@gunan @sjamesr I have added more header files.

  • tensorflow/c/tf_attrtype.h
  • tensorflow/c/tf_datatype.h
  • tensorflow/c/tf_status.h
  • tensorflow/c/tf_tensor.h

Is this enough? Is tensorflow/c/c_api_experimental.h needed?

@gbaned gbaned requested a review from gunan July 31, 2019 09:07
@tensorflow-bot tensorflow-bot bot added the kokoro:force-run Tests on submitted change label Jul 31, 2019
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jul 31, 2019
@gunan
Copy link
Contributor

gunan commented Jul 31, 2019

I do not think we need c_api_experimental. That header is meant to be unstable, and should not be dedpended on by end users.

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 31, 2019
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 1, 2019
@tensorflow-copybara tensorflow-copybara merged commit 9d95313 into tensorflow:master Aug 3, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Aug 3, 2019
tensorflow-copybara pushed a commit that referenced this pull request Aug 3, 2019
PiperOrigin-RevId: 261444666
@d02k01 d02k01 deleted the patch-1 branch August 4, 2019 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants