Override zip on AutoGraph #31290
Merged
Override zip on AutoGraph #31290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanatg
previously approved these changes
Aug 2, 2019
tensorflow-bot
bot
added
kokoro:force-run
|
Hmm, why there's an error happened while migrating the change? Is there anything I needed to fix? |
rthadur
added
ready to pull
|
Can one of the admins verify this patch? |
tensorflow-copybara
pushed a commit
that referenced
this pull request
Aug 20, 2019
PiperOrigin-RevId: 264434788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request address what @mdanatg said on #31038 PR about overriding zip on AutoGraph. The current implementation override zip when all of the input was dataset. But when not all of it was a dataset, it will execute the built-in python zip. Is this the correct behaviour?