Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 3D Conv and Deconv TensorRT acceleration, with unit tests #31461

Merged
merged 2 commits into from
Aug 19, 2019

Conversation

madenton
Copy link
Contributor

@madenton madenton commented Aug 8, 2019

I add 3D node conversion for Tensorflow-TensorRT (TF-TRT), so inference of 3D CNN's are accelerated using TensorRT. Supported nodes are Conv3D and Conv3DBackpropInputV2, which enables convolution and deconvolution respectively. Associated unit tests are included.

@tensorflow-bot tensorflow-bot bot added the size:L CL Change Size: Large label Aug 8, 2019
@trevor-m trevor-m added the kokoro:force-run Tests on submitted change label Aug 8, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 8, 2019
@rthadur rthadur self-assigned this Aug 8, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Aug 8, 2019
@rthadur rthadur requested a review from aaroey August 8, 2019 23:14
@rthadur rthadur added the comp:gpu GPU related issues label Aug 8, 2019
Copy link
Member

@aaroey aaroey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! Here are just some minor formatting issues.

tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2tensorrt/convert/convert_nodes.cc Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Aug 14, 2019
@madenton
Copy link
Contributor Author

@aaroey I've made the changes requested. Can you please review?

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Aug 15, 2019
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 15, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 15, 2019
tensorflow-copybara pushed a commit that referenced this pull request Aug 19, 2019
PiperOrigin-RevId: 264233525
@tensorflow-copybara tensorflow-copybara merged commit 3725174 into tensorflow:master Aug 19, 2019
PR Queue automation moved this from Approved by Reviewer to Merged Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:gpu GPU related issues ready to pull PR ready for merge process size:L CL Change Size: Large
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants