Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using more precise log #33055

Closed
wants to merge 7 commits into from
Closed

Using more precise log #33055

wants to merge 7 commits into from

Conversation

autoih
Copy link
Member

@autoih autoih commented Oct 4, 2019

Using log(1+x) to compute when x is close to zero

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Oct 4, 2019
@rthadur rthadur self-assigned this Oct 4, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Oct 4, 2019
@rthadur rthadur added the comp:xla XLA label Oct 4, 2019
@rthadur rthadur requested a review from sanjoy October 4, 2019 21:19
@sanjoy sanjoy requested review from bixia1 and removed request for sanjoy October 4, 2019 21:41
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 7, 2019
bixia1
bixia1 previously approved these changes Oct 7, 2019
tensorflow/compiler/xla/client/lib/math.cc Outdated Show resolved Hide resolved
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 7, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 7, 2019
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Oct 7, 2019
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Oct 8, 2019
bixia1
bixia1 previously approved these changes Oct 8, 2019
tensorflow/compiler/xla/client/lib/math.cc Outdated Show resolved Hide resolved
@tensorflow-bot tensorflow-bot bot added the kokoro:force-run Tests on submitted change label Oct 8, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 8, 2019
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Oct 8, 2019
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Oct 8, 2019
@tensorflow-bot tensorflow-bot bot added the kokoro:force-run Tests on submitted change label Oct 8, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 8, 2019
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 8, 2019
tensorflow-copybara pushed a commit that referenced this pull request Oct 9, 2019
This is to prepare for PR #33055.

PiperOrigin-RevId: 273767416
@rthadur
Copy link
Contributor

rthadur commented Oct 9, 2019

Seems auto-merge is not happening but the changes are now committed so we can close this. Thank you for the PR.

@rthadur rthadur closed this Oct 9, 2019
PR Queue automation moved this from Approved by Reviewer to Closed/Rejected Oct 9, 2019
tensorflow-copybara pushed a commit that referenced this pull request Oct 9, 2019
PiperOrigin-RevId: 273810419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:xla XLA ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Closed/Rejected
Development

Successfully merging this pull request may close these issues.

None yet

5 participants