Improve math_ops.py docs #34014
Merged
Improve math_ops.py docs #34014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added usage examples to the tf.math.cumsum() docstring. What exists currently is syntax-like declarations and not `self contained` code samples.
Added a usage example and description of the function parameters and return values
|
@yashk2810 can you help re-review this. I've cleared some commits off the log from the previous pull request (referenced above). Thanks |
yashk2810
reviewed
Nov 6, 2019
| ```python | ||
| tf.cumsum([a, b, c], exclusive=True) # [0, a, a + b] | ||
| ``` | ||
| # tf.cumsum([a, b, c], exclusive=True) => [0, a, a + b] |
There was a problem hiding this comment.
Can you please add a newline before this comment and everywhere else?
Something like this
By setting the `exclusive` kwarg to `True`, an exclusive cumsum is performed instead:
# tf.cumsum([a, b, c], exclusive=True) => [0, a, a + b]
There was a problem hiding this comment.
changes implemented as requested
yashk2810
previously approved these changes
Nov 7, 2019
tensorflow-bot
bot
added
kokoro:force-run
stmugisha
force-pushed
the
steph-en-m-patch-1
branch
from
9d57f02
to
56aea64
Compare
|
The ubuntu cpu test was failing at tf.cumsum so I've made minor changes to the doctest to make it pass. |
yashk2810
previously approved these changes
Nov 11, 2019
stmugisha
force-pushed
the
steph-en-m-patch-1
branch
from
56aea64
to
6f2c716
Compare
|
ubuntu sanity check was failing due to a pylint error( |
rthadur
approved these changes
Nov 11, 2019
rthadur
added
ready to pull
tensorflow-copybara
pushed a commit
that referenced
this pull request
Nov 12, 2019
PiperOrigin-RevId: 279851681 Change-Id: Icf3296866d10ac23e2e2e50199a73a84cbb4becf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.