New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] Fix for the broken ROCm CSB. #34104
[ROCm] Fix for the broken ROCm CSB. #34104
Conversation
The following commit breaks the --config=rocm build tensorflow@f72695e The above commit adds a couple of subtests that require support for the `StatefulUnirformFullInt` Op on the GPU. Currently ROCm does not support that Op on the GPU, which leads to those subtests failing. The "fix" is to skip those subtests on the ROCm platform.
@chsigg @tanzhenyu gentle ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why is this needed -- where is StatefulUniformFullInt used? I think the layer was only using stateless random ops.
The error message we get for the failure indicates that
|
@chsigg @tanzhenyu gentle ping |
@gbaned , anything we can do to help get this PR merged? |
…ocm_fix_191108 PiperOrigin-RevId: 282922989 Change-Id: Id75e811dc0668a448800b712fe86975ac76ae991
The following commit breaks the --config=rocm build
f72695e
The above commit adds a couple of subtests that require support for the
StatefulUnirformFullInt
Op on the GPU. Currently ROCm does not support that Op on the GPU, which leads to those subtests failing.The "fix" is to skip those subtests on the ROCm platform.
/cc @chsigg @whchung