Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise error in tf.math.polyval for non-list coeffs #36597

Merged
merged 3 commits into from Feb 12, 2020
Merged

raise error in tf.math.polyval for non-list coeffs #36597

merged 3 commits into from Feb 12, 2020

Conversation

rushabh-v
Copy link
Contributor

resolves #34947

@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Feb 9, 2020
@gbaned gbaned self-assigned this Feb 10, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 10, 2020
@gbaned gbaned added the prtype:bugfix PR to fix a bug label Feb 10, 2020
mihaimaruseac
mihaimaruseac previously approved these changes Feb 10, 2020
View reviewed changes
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Feb 10, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 10, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 10, 2020
@gbaned
Copy link
Contributor

gbaned commented Feb 11, 2020

@rushabh-v Can you please fix the build failures? Thanks!

@gbaned gbaned removed the ready to pull PR ready for merge process label Feb 11, 2020
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Feb 11, 2020
@rushabh-v
Copy link
Contributor Author

Didn't know the system of TF of using test.Testcase for tests. corrected the tests. I think it's okay now. @mihaimaruseac Can you please review it again?

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Feb 11, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 11, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Feb 12, 2020
tensorflow-copybara pushed a commit that referenced this pull request Feb 12, 2020
@tensorflower-gardener
Merge pull request #36597 from rushabh-v:er-poly
0ec37eb 
PiperOrigin-RevId: 294598208
Change-Id: I7d17dfc9ae5984d6303798aa7c09aba42703355f
@tensorflow-copybara tensorflow-copybara merged commit b664a40 into tensorflow:master Feb 12, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes prtype:bugfix PR to fix a bug ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

polyval gives TypeError when run inside tf.function with Tensor coeffs, but not when run eagerly
6 participants
@rushabh-v @gbaned @mihaimaruseac @googlebot @kokoro-team @tensorflow-copybara