Undo changes to the input spec when RNN.unroll is True. #37374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 298492355 Change-Id: I442ad2a23576cae8fa2fad02a27a199f13b159c1
mihaimaruseac
approved these changes
Mar 5, 2020
…cherrypicks_SXE8X
goldiegadde
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from fc7116d that made the input spec more stringent do not apply to all unrolled recurrent layers. I'll have to revisit b/148491963 later.
PiperOrigin-RevId: 298492355
Change-Id: I442ad2a23576cae8fa2fad02a27a199f13b159c1