New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for check_pydot when Graphviz is not installed #37385
Fix for check_pydot when Graphviz is not installed #37385
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Dug into Might want to do a test based on the patching pattern found there to confirm this. |
Currently, if
pydot
is installed, butGraphviz
is not,check_pydot
will raise apydot.InvocationException
instead of returning False. This PR should fix this issue.Should probably add a test to confirm the issue, but I wasn't entirely sure how best to go about it, so holding off on it for now.