Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for check_pydot when Graphviz is not installed #37385

Merged
merged 2 commits into from Mar 13, 2020

Conversation

harahu
Copy link
Contributor

@harahu harahu commented Mar 6, 2020

Currently, if pydot is installed, but Graphviz is not, check_pydot will raise a pydot.InvocationException instead of returning False. This PR should fix this issue.

Should probably add a test to confirm the issue, but I wasn't entirely sure how best to go about it, so holding off on it for now.

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Mar 6, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 6, 2020
@gbaned gbaned self-assigned this Mar 6, 2020
@gbaned gbaned added the comp:keras Keras related issues label Mar 6, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 6, 2020
@gbaned gbaned requested a review from pavithrasv March 6, 2020 12:04
@gbaned gbaned added the awaiting review Pull request awaiting review label Mar 11, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 13, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 13, 2020
@gbaned gbaned added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 13, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 13, 2020
@harahu
Copy link
Contributor Author

harahu commented Mar 13, 2020

Dug into pydota bit and found this: https://github.com/pydot/pydot-ng/blob/8817b2141008c4b74507efb1b7711da7caa77684/test/test_pydot.py#L197-L204

Might want to do a test based on the patching pattern found there to confirm this.

@tensorflow-copybara tensorflow-copybara merged commit ff844e3 into tensorflow:master Mar 13, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants