Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a compile error of r2.1 caused by skylib address invalid. #37775

Merged
merged 1 commit into from May 12, 2020

Conversation

rhdong
Copy link
Member

@rhdong rhdong commented Mar 21, 2020

fix a compile error of r2.1 caused by the invalid link of skylib.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@gbaned
Copy link
Contributor

gbaned commented Mar 23, 2020

@rhdong Can you please sign CLA ? Thanks!

@gbaned gbaned self-assigned this Mar 23, 2020
@gbaned gbaned added the size:XS CL Change Size: Extra Small label Mar 23, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 23, 2020
@mihaimaruseac
Copy link
Collaborator

Please sign CLA and open against master and then cherry-pick here.

If master already works, we should cherry-pick the commit fixing there.

Note that since this is against 2.1 branch we won't merge it until we need to do a patch release (for security reasons)

@mihaimaruseac mihaimaruseac added the waiting for patch release PR will be reviewed and merged only if we do a patch release since PR is not on master branch label Mar 25, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mihaimaruseac
Copy link
Collaborator

We can only merge this when we do a patch release on the 2.1 release

@mihaimaruseac mihaimaruseac added the kokoro:force-run Tests on submitted change label May 8, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 8, 2020
@mihaimaruseac mihaimaruseac added the kokoro:force-run Tests on submitted change label May 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 11, 2020
@mihaimaruseac mihaimaruseac added the kokoro:force-run Tests on submitted change label May 12, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer May 12, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 12, 2020
@mihaimaruseac mihaimaruseac merged commit 722e184 into tensorflow:r2.1 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:XS CL Change Size: Extra Small waiting for patch release PR will be reviewed and merged only if we do a patch release since PR is not on master branch
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

5 participants