Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some of the XLA tests for IBM's Power architecture #38980

Closed

Conversation

npanpaliya
Copy link
Contributor

On IBM Power, some of the XLA tests used to fail with error "no target available for host triple x86..".
So, the PR tries to fix it in a way that it works on Power as well as x86. Other platforms can add their cases in cpu_compiler.h for these tests to work for them.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Apr 28, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@gbaned gbaned self-assigned this Apr 28, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 28, 2020
@gbaned
Copy link
Contributor

gbaned commented Apr 28, 2020

@npanpaliya Thank you for your contribution. Can you please sign CLA? Thanks!

@npanpaliya
Copy link
Contributor Author

Being an IBM Contractor, I've previously committed to this repo with appropriate Corporate CLA. It's just that my email has been changed now from "nishidha@us.ibm.com" to "npanpa23@in.ibm.com".

@rthadur
Copy link
Contributor

rthadur commented Apr 28, 2020

@npanpaliya you should sign with all the emails associated, thank you

@npanpaliya
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 2, 2020
@gbaned gbaned added the comp:xla XLA label May 4, 2020
@gbaned gbaned requested a review from sanjoy May 4, 2020 15:27
@gbaned gbaned added the awaiting review Pull request awaiting review label May 8, 2020
@npanpaliya
Copy link
Contributor Author

@sanjoy and @joker-eph - Could you please review this PR?

Copy link
Contributor

@sanjoy sanjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share if you're using XLA CPU on IBM Power? Please feel free to follow up over private email (sanjoy AT {my employer}.com).

Thanks!

PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes May 21, 2020
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label May 23, 2020
@npanpaliya
Copy link
Contributor Author

Can you share if you're using XLA CPU on IBM Power? Please feel free to follow up over private email (sanjoy AT {my employer}.com).

Thanks!

Yes.

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label May 27, 2020
@gbaned
Copy link
Contributor

gbaned commented Jun 2, 2020

@npanpaliya Any update on this PR? Please. Thanks!

@npanpaliya
Copy link
Contributor Author

@gbaned - I'm sorry for the delay. I've done the suggested changes. But due to some other high priority work, could not test and push those. I'll do it tomorrow for sure.

@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Jun 4, 2020
@npanpaliya
Copy link
Contributor Author

I'm really sorry for not being able to push my changes which address the review comments. I've been facing the build failure since yesterday due to ruy update. The latest ruy version being used by TF doesn't work on Power.

@npanpaliya
Copy link
Contributor Author

I've put a PR to fix ruy on Power. google/ruy#83
Once this is accepted and merged, I'll raise another PR to bump up the version of ruy to the one that has fix for Power.

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 16, 2020
@gbaned gbaned added the kokoro:force-run Tests on submitted change label Jun 16, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 16, 2020
@rthadur
Copy link
Contributor

rthadur commented Jun 16, 2020

@npanpaliya can you please check build failures ?

@gbaned gbaned removed the ready to pull PR ready for merge process label Jun 17, 2020
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Jun 17, 2020
@npanpaliya
Copy link
Contributor Author

@rthadur - I've fixed the build error. Thanks!

@rthadur rthadur requested a review from sanjoy June 17, 2020 16:25
@rthadur rthadur added the kokoro:force-run Tests on submitted change label Jun 17, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 17, 2020
rthadur
rthadur previously approved these changes Jun 17, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jun 17, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 17, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 17, 2020
@gbaned gbaned added the kokoro:force-run Tests on submitted change label Jun 18, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 18, 2020
@gbaned
Copy link
Contributor

gbaned commented Jun 18, 2020

@npanpaliya Can you please address Ubuntu Sanity errors? Thanks!

@gbaned gbaned removed the ready to pull PR ready for merge process label Jun 18, 2020
@npanpaliya
Copy link
Contributor Author

I've been looking at them but I don't really understand what is the problem now.

@npanpaliya
Copy link
Contributor Author

I've fixed the BUILD files using bazel buildifier utility. Hopefully all checks should be fine now.

PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Jun 18, 2020
tensorflow-copybara pushed a commit that referenced this pull request Jun 18, 2020
PiperOrigin-RevId: 317063007
Change-Id: Ic11ae94c2e409207658e2dc9558e0f8cbbdee984
@rthadur
Copy link
Contributor

rthadur commented Jun 18, 2020

Seems auto-merge is not happening but the changes are now committed so we can close this. Thank you for the PR.

@rthadur rthadur closed this Jun 18, 2020
PR Queue automation moved this from Reviewer Requested Changes to Closed/Rejected Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:xla XLA size:S CL Change Size: Small
Projects
PR Queue
  
Closed/Rejected
Development

Successfully merging this pull request may close these issues.

None yet

8 participants