New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some of the XLA tests for IBM's Power architecture #38980
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@npanpaliya Thank you for your contribution. Can you please sign CLA? Thanks! |
Being an IBM Contractor, I've previously committed to this repo with appropriate Corporate CLA. It's just that my email has been changed now from "nishidha@us.ibm.com" to "npanpa23@in.ibm.com". |
@npanpaliya you should sign with all the emails associated, thank you |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@sanjoy and @joker-eph - Could you please review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share if you're using XLA CPU on IBM Power? Please feel free to follow up over private email (sanjoy AT {my employer}.com).
Thanks!
Yes. |
@npanpaliya Any update on this PR? Please. Thanks! |
@gbaned - I'm sorry for the delay. I've done the suggested changes. But due to some other high priority work, could not test and push those. I'll do it tomorrow for sure. |
I'm really sorry for not being able to push my changes which address the review comments. I've been facing the build failure since yesterday due to ruy update. The latest ruy version being used by TF doesn't work on Power. |
I've put a PR to fix ruy on Power. google/ruy#83 |
b2dc407
to
bdf6adf
Compare
@npanpaliya can you please check build failures ? |
@rthadur - I've fixed the build error. Thanks! |
@npanpaliya Can you please address Ubuntu Sanity errors? Thanks! |
I've been looking at them but I don't really understand what is the problem now. |
I've fixed the BUILD files using bazel buildifier utility. Hopefully all checks should be fine now. |
PiperOrigin-RevId: 317063007 Change-Id: Ic11ae94c2e409207658e2dc9558e0f8cbbdee984
Seems auto-merge is not happening but the changes are now committed so we can close this. Thank you for the PR. |
On IBM Power, some of the XLA tests used to fail with error "no target available for host triple x86..".
So, the PR tries to fix it in a way that it works on Power as well as x86. Other platforms can add their cases in cpu_compiler.h for these tests to work for them.