Fix #39462 #39728
Merged
Fix #39462 #39728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
approved these changes
Nov 12, 2020
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
get_valueto retrieve the value for LR, we receive a np.float32. However when we cast this to a python float, there are unwanted trailing significant digits added to our value that causes old_lr to never be exactly equal to our supplied min_lr, despite it being equal internally.By leaving old_lr as it's original np.float32, and by casting our supplied min_lr to np.float32, we are now able to properly compare the values and the block of code should not be executed again after lr has been set to min_lr.