Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added allocate_temp to op kernel methods and refactored tests for kernels #40854

Merged
merged 10 commits into from Jul 23, 2020
Merged

Added allocate_temp to op kernel methods and refactored tests for kernels #40854

merged 10 commits into from Jul 23, 2020

Conversation

dnguyen28061
Copy link
Contributor

@dnguyen28061 dnguyen28061 commented Jun 26, 2020 •
edited

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jun 26, 2020
annarev
annarev reviewed Jun 26, 2020
View reviewed changes
tensorflow/c/kernels.cc Outdated Show resolved Hide resolved
tensorflow/c/kernels.cc Outdated Show resolved Hide resolved
tensorflow/c/kernels.h Outdated Show resolved Hide resolved
tensorflow/c/kernels.h Outdated Show resolved Hide resolved
tensorflow/c/kernels.cc Outdated Show resolved Hide resolved
@gbaned gbaned self-assigned this Jun 29, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jun 29, 2020
@gbaned gbaned requested a review from annarev July 1, 2020 08:33
annarev
annarev reviewed Jul 1, 2020
View reviewed changes
tensorflow/c/kernels.cc Outdated Show resolved Hide resolved
@gbaned
Copy link
Contributor

gbaned commented Jul 6, 2020

@dnguyen28061 Can you please check @annarev's comments and keep us posted. Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Jul 6, 2020
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 6, 2020
@dnguyen28061
Copy link
Contributor Author

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 6, 2020
@gbaned gbaned removed the stat:awaiting response Status - Awaiting response from author label Jul 7, 2020
@gbaned gbaned requested a review from annarev July 7, 2020 15:18
@gbaned gbaned requested review from annarev and removed request for annarev July 10, 2020 14:07
@gbaned gbaned removed their assignment Jul 14, 2020
@tensorflow-copybara tensorflow-copybara merged commit 878b450 into tensorflow:master Jul 23, 2020
PR Queue automation moved this from Assigned Reviewer to Merged Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annarev annarev Awaiting requested review from annarev

Assignees
No one assigned
Labels
cla: yes size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dnguyen28061 @gbaned @googlebot @annarev @tensorflow-copybara