Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nvcc compiler-options #40941

Merged
merged 1 commit into from
Jun 30, 2020
Merged

fix nvcc compiler-options #40941

merged 1 commit into from
Jun 30, 2020

Conversation

fo40225
Copy link
Contributor

@fo40225 fo40225 commented Jun 30, 2020

ref. https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/#options-for-passing-specific-phase-options-compiler-options

The host compiler parameter should be separated by commas instead of spaces.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jun 30, 2020
@gbaned gbaned self-assigned this Jun 30, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jun 30, 2020
@gbaned gbaned requested a review from chsigg June 30, 2020 14:01
chsigg
chsigg approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@chsigg chsigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jun 30, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 30, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 30, 2020
@tensorflow-copybara tensorflow-copybara merged commit 4f5ffbc into tensorflow:master Jun 30, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsigg chsigg chsigg approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fo40225 @chsigg @googlebot @kokoro-team @tensorflow-copybara @gbaned