[INTEL MKL] Pad+Conv fusion for bf16 #41010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShengYang1
force-pushed
the
yang/pad_conv_fusion
branch
from
668e9b4
to
81a475d
Compare
penpornk
requested changes
Jul 14, 2020
| const int image_batch_count = 1; | ||
| Tensor image(DT_FLOAT, {image_batch_count, image_height, image_width, depth}); | ||
| test::FillValues<float>(&image, {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12}); | ||
| TYPED_TEST_CASE_P(FusedPadConvOpTest); |
There was a problem hiding this comment.
This is deprecated. Please use TYPED_TEST_SUITE_P instead.
Suggested change
| TYPED_TEST_CASE_P(FusedPadConvOpTest); | |
| TYPED_TEST_SUITE_P(FusedPadConvOpTest); |
| const int image_batch_count = 1; | ||
| Tensor image(DT_FLOAT, {image_batch_count, depth, image_height, image_width}); | ||
| test::FillValues<float>(&image, {1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12}); | ||
| REGISTER_TYPED_TEST_CASE_P(FusedPadConvOpTest, PaddingConvTest, |
There was a problem hiding this comment.
Also deprecated.
Suggested change
| REGISTER_TYPED_TEST_CASE_P(FusedPadConvOpTest, PaddingConvTest, | |
| REGISTER_TYPED_TEST_SUITE_P(FusedPadConvOpTest, PaddingConvTest, |
| #else | ||
| using FusedPadConvDataTypes = ::testing::Types<float>; | ||
| #endif | ||
| INSTANTIATE_TYPED_TEST_CASE_P(Test, FusedPadConvOpTest, FusedPadConvDataTypes); |
There was a problem hiding this comment.
Suggested change
| INSTANTIATE_TYPED_TEST_CASE_P(Test, FusedPadConvOpTest, FusedPadConvDataTypes); | |
| INSTANTIATE_TYPED_TEST_SUITE_P(Test, FusedPadConvOpTest, FusedPadConvDataTypes); |
There was a problem hiding this comment.
Thanks for review. All TYPED_TEST_CASE_P in this file have been replaced
penpornk
approved these changes
Jul 14, 2020
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables pad+conv fusion for bf16 and related test case.