Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update array_ops.py #41044

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Update array_ops.py #41044

merged 1 commit into from
Jul 6, 2020

Conversation

aavishkarmishra
Copy link
Contributor

Updated the line 4487 according to issue #41005, previous pull request #41037

Now documentation says :

x is a Tensor which is of same type as y, and has a shape broadcastable with condition and y.
y is a Tensor which is of same type as x, and has a shape broadcastable with condition and x.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jul 2, 2020
@aavishkarmishra aavishkarmishra mentioned this pull request Jul 2, 2020
Closed
@gbaned gbaned self-assigned this Jul 3, 2020
@gbaned gbaned added the comp:ops OPs related issues label Jul 3, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 3, 2020
@gbaned gbaned requested a review from mihaimaruseac July 3, 2020 04:14
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 3, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 3, 2020
@mihaimaruseac
Copy link
Collaborator

Nit: Should have used the same PR, just amend the commit / add a new one.

Also, note that in general we don't accept a single line non-functional change PR as the amount of CI time needed for the integrate is too large compared to the gains of the change. In the future, when fixing typos, try to fix all typos in a file/directory/API area.

@aavishkarmishra
Copy link
Contributor Author

Sorry for that, I will make sure this will not happen again.

@tensorflow-copybara tensorflow-copybara merged commit 45ab79c into tensorflow:master Jul 6, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Jul 6, 2020
@mihaimaruseac mihaimaruseac mentioned this pull request Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:ops OPs related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aavishkarmishra @mihaimaruseac @googlebot @kokoro-team @tensorflow-copybara @gbaned