Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix docker envs #41064

Merged
merged 1 commit into from Aug 7, 2020
Merged

fix docker envs #41064

merged 1 commit into from Aug 7, 2020

Conversation

fsx950223
Copy link
Member

@fsx950223 fsx950223 commented Jul 3, 2020 •
edited

Related #4078 #4267

libcuda.so always under /usr/lib/x86_64-linux-gnu/

Screenshot from 2020-07-07 12-53-25

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jul 3, 2020
@gbaned gbaned self-assigned this Jul 3, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 3, 2020
@gbaned gbaned requested a review from angerson July 3, 2020 14:40
@gbaned gbaned added the awaiting review Pull request awaiting review label Jul 6, 2020
@gbaned
Copy link
Contributor

gbaned commented Jul 9, 2020

@angerson Can you please review this PR ? Thanks!

1 similar comment
@gbaned
Copy link
Contributor

gbaned commented Aug 3, 2020

@angerson Can you please review this PR ? Thanks!

angerson
angerson suggested changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@angerson angerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you follow the directions in the tools/dockerfiles directory to update the partials and regenerate all the relevant files, please?

PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Aug 3, 2020
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Aug 5, 2020
@fsx950223 fsx950223 requested a review from angerson August 6, 2020 08:36
@gbaned gbaned requested review from angerson and removed request for angerson August 6, 2020 16:47
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Aug 6, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 6, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 6, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 7, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 7, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 7, 2020
@tensorflow-copybara tensorflow-copybara merged commit f10eb87 into tensorflow:master Aug 7, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerson angerson angerson approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@fsx950223 @gbaned @angerson @googlebot @kokoro-team @tensorflowbutler @tensorflow-copybara