-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update output_handler.cc #41088
Update output_handler.cc #41088
Conversation
fix incorrectly documented led-color order
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR but I don't think this is worth the hours of CI it will take to integrate it. There are ongoing PRs which fix typos across an entire directory, and I think they already cover this too.
No problem. Thought I would just report it and provide this small fix. I
see that another one was fixed already. If you start with tensortlow, it's
just nice that your first example is completely correct. Kind regards
Op zo 5 jul. 2020 09:32 schreef TommyWang <notifications@github.com>:
… ***@***.**** commented on this pull request.
Thank you for the PR but I don't think this is worth the hours of CI it
will take to integrate it. There are ongoing PRs which fix typos across an
entire directory, and I think they already cover this too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#41088 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ7X3RLMBLPZG4A2SJNATLR2AUBHANCNFSM4OQSHHPQ>
.
|
fix incorrectly documented led-color order