Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update output_handler.cc #41088

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

MichelBr
Copy link
Contributor

@MichelBr MichelBr commented Jul 4, 2020

fix incorrectly documented led-color order

fix incorrectly documented led-color order
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jul 4, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@MichelBr
Copy link
Contributor Author

MichelBr commented Jul 4, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 4, 2020
Copy link
Contributor

@Dynmi Dynmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR but I don't think this is worth the hours of CI it will take to integrate it. There are ongoing PRs which fix typos across an entire directory, and I think they already cover this too.

@MichelBr
Copy link
Contributor Author

MichelBr commented Jul 5, 2020 via email

@gbaned gbaned self-assigned this Jul 6, 2020
@gbaned gbaned added comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers labels Jul 6, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 6, 2020
@gbaned gbaned requested a review from njeffrie July 6, 2020 04:26
@gbaned gbaned added the awaiting review Pull request awaiting review label Jul 9, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 3, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 3, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 3, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Aug 4, 2020
@tensorflow-copybara tensorflow-copybara merged commit 572d7a7 into tensorflow:master Aug 4, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:lite TF Lite related issues comp:micro Related to TensorFlow Lite Microcontrollers ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

7 participants