cmsis-nn: Revert dynamic allocation for quant params #41121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File affected: cmsis-nn/depthwise_conv.cc Dynamic allocation of memory for output shift and multiplier fails(running whole networks) when done together with scratch buffer for optimization. The issue is tracked in b/158779832. This patch reverts back to static allocation for output shift and multiplier until the scratch buffer issue is fixed.
gbaned
added
comp:lite
Dynmi
approved these changes
Jul 6, 2020
google-ml-butler
bot
added
kokoro:force-run
MeghnaNatraj
requested review from
petewarden and
advaitjain
and removed request for
MeghnaNatraj
advaitjain
approved these changes
Jul 6, 2020
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File affected: cmsis-nn/depthwise_conv.cc
Dynamic allocation of memory for output shift and
multiplier fails(running whole networks) when
done together with scratch buffer for
optimization. The issue is tracked in b/158779832.
This patch reverts back to static allocation
for output shift and multiplier until the scratch buffer
issue is fixed.