Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign compare warning fixes batch 9 #41145

Merged
merged 4 commits into from
Jul 8, 2020
Merged

Sign compare warning fixes batch 9 #41145

merged 4 commits into from
Jul 8, 2020

Conversation

tg-at-google
Copy link
Contributor

in resolution of [-Wsign-compare] warnings with ids:
[
231, 237, 289, 291, 292, 304, 384,
387, 389, 390, 391, 392, 393, 394,
385, 395, 398, 399, 400, 407, 478,
519
]

@mihaimaruseac

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jul 7, 2020
@google-ml-butler google-ml-butler bot requested a review from joker-eph July 7, 2020 01:49
@gbaned gbaned self-assigned this Jul 7, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 7, 2020
@gbaned gbaned requested a review from mihaimaruseac July 7, 2020 07:32
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Jul 7, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jul 7, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 7, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 7, 2020
@mihaimaruseac
Copy link
Collaborator 

tensorflow/compiler/mlir/tensorflow/transforms/promote_resources_to_args.cc:345:36: error: 'eturn_operands' was not declared in this scope
   const int return_operands_size = eturn_operands.size();
                                    ^~~~~~~~~~~~~~
tensorflow/compiler/mlir/tensorflow/transforms/promote_resources_to_args.cc:345:36: note: suggested alternative: 'return_operands'
   const int return_operands_size = eturn_operands.size();
                                    ^~~~~~~~~~~~~~
                                    return_operands

@tg-at-google
Copy link
Contributor Author 

tensorflow/compiler/mlir/tensorflow/transforms/promote_resources_to_args.cc:345:36: error: 'eturn_operands' was not declared in this scope
   const int return_operands_size = eturn_operands.size();
                                    ^~~~~~~~~~~~~~
tensorflow/compiler/mlir/tensorflow/transforms/promote_resources_to_args.cc:345:36: note: suggested alternative: 'return_operands'
   const int return_operands_size = eturn_operands.size();
                                    ^~~~~~~~~~~~~~
                                    return_operands

This is a file it seems I did not change.

@mihaimaruseac
Copy link
Collaborator

Right, it was a transient error fixed in the meanwhile

@tensorflow-copybara tensorflow-copybara merged commit 7e5cdee into tensorflow:master Jul 8, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@joker-eph joker-eph Awaiting requested review from joker-eph

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tg-at-google @mihaimaruseac @googlebot @kokoro-team @tensorflow-copybara @gbaned