Add Rename, Copy, Delete recursively #41192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaimaruseac
approved these changes
Jul 8, 2020
google-ml-butler
bot
added
kokoro:force-run
|
Sorry, I missed your question about the test suite. I will probably not get to it this week due to a very urgent high priority task unfortunately. |
|
No need to worry. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I add 3 function for
gcsand some comments about the behavior ofgcs_filesystem.google-cloud-cppis missing a feature which allows us to mimic the current implementation so I am asking the maintainer team. Here is the link googleapis/google-cloud-cpp#4482 .In the meantime, I will work on
s3. I will send you PR forgcstoo but they will work as a cloud filesystem rather than local filesystem ( When the feature is ready, I will send you some PRs to mimic the current implementation )And how are the bugs in
modular_filesystem_testgoing ?