Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove repeated call in FindKernelDef #41261

Merged
merged 2 commits into from
Jul 20, 2020
Merged

Remove repeated call in FindKernelDef #41261

merged 2 commits into from
Jul 20, 2020

Conversation

zhuzilin
Copy link
Contributor

Thank you for your time on reviewing this pr.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jul 10, 2020
@gbaned gbaned self-assigned this Jul 16, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 16, 2020
mihaimaruseac
mihaimaruseac reviewed Jul 16, 2020
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's also make device_str to be const on line 1416

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 17, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 17, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 17, 2020
@tensorflow-copybara tensorflow-copybara merged commit 320f227 into tensorflow:master Jul 20, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Jul 20, 2020
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:core issues related to core part of tensorflow ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zhuzilin @mihaimaruseac @googlebot @kokoro-team @tensorflow-copybara @gbaned