Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TFLite] Error reporting message does not include name of the operator. #41275

Merged
merged 1 commit into from
Jul 13, 2020
Merged

[TFLite] Error reporting message does not include name of the operator. #41275

merged 1 commit into from
Jul 13, 2020

Conversation

wwwind
Copy link
Contributor

@wwwind wwwind commented Jul 10, 2020

This is a small fix for the regression in the error reporting in the quantize model function:
the name of the operator was not included.

@wwwind
Fix for quantize_model error reporting.
7958d97 
Change-Id: Icffdece7804a60beb4b59eb347738457c81b9986
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jul 10, 2020
@wwwind
Copy link
Contributor Author

wwwind commented Jul 10, 2020

Hi @jdduke Could you please review this small fix for the regression ? Thanks!

@gbaned gbaned self-assigned this Jul 10, 2020
@gbaned gbaned added the comp:lite TF Lite related issues label Jul 10, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 10, 2020
@gbaned gbaned requested a review from jdduke July 10, 2020 11:20
@wwwind
Copy link
Contributor Author

wwwind commented Jul 10, 2020

Hi @jdduke This is a regression introduced by me in that long PR for 16x8. It will be great if it could be cherry-picked into 2.3. Thanks

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 10, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 10, 2020
@jdduke
Copy link
Member

jdduke commented Jul 10, 2020

Too late for a 2.3 cherrypick, unfortunately, but thanks for fixing.

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 10, 2020
@tensorflow-copybara tensorflow-copybara merged commit afb4294 into tensorflow:master Jul 13, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdduke jdduke jdduke approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:lite TF Lite related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wwwind @jdduke @googlebot @kokoro-team @tensorflow-copybara @gbaned