Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary op bm #41297

Merged
merged 4 commits into from
Aug 27, 2020
Merged

Summary op bm #41297

merged 4 commits into from
Aug 27, 2020

Conversation

dnguyen28061
Copy link
Contributor

@annarev @bmzhao
Added benchmarking for SummaryScalar Op. Awaiting summary_op merge before adding build dependencies for this benchmark.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jul 10, 2020
annarev
annarev reviewed Aug 7, 2020
View reviewed changes
Copy link
Contributor

@annarev annarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not checking this PR earlier. It somehow slipped through the cracks.

tensorflow/c/kernels/summary_op_benchmark_test.cc Outdated Show resolved Hide resolved
tensorflow/c/kernels/summary_op_benchmark_test.cc Outdated Show resolved Hide resolved
@annarev annarev requested a review from bmzhao August 10, 2020 23:41
bmzhao
bmzhao previously approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@bmzhao bmzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! Added some minor nits.

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 11, 2020
@rthadur rthadur removed the ready to pull PR ready for merge process label Aug 11, 2020
@dnguyen28061 dnguyen28061 force-pushed the summary_op_bm branch 2 times, most recently from 17d0697 to 59292e1 Compare August 12, 2020 21:22
@dnguyen28061 dnguyen28061 force-pushed the summary_op_bm branch 3 times, most recently from bf962eb to 6b81209 Compare August 24, 2020 20:08
annarev
annarev previously approved these changes Aug 24, 2020
View reviewed changes
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 24, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 24, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Aug 25, 2020
annarev
annarev previously approved these changes Aug 25, 2020
View reviewed changes
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 25, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 25, 2020
annarev
annarev reviewed Aug 26, 2020
View reviewed changes
tensorflow/c/kernels/BUILD Show resolved Hide resolved
tensorflow/c/kernels/summary_op_benchmark_test.cc Show resolved Hide resolved
tensorflow/c/kernels/summary_op_benchmark_test.cc Outdated Show resolved Hide resolved
tensorflow/c/kernels/summary_op_benchmark_test.cc Outdated Show resolved Hide resolved
tensorflow/c/kernels/summary_op_benchmark_test.cc Outdated Show resolved Hide resolved
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Aug 26, 2020
@dnguyen28061
Merge branch 'master' of https://github.com/tensorflow/tensorflow into
d41aa7a 
summary_op_bm and added BUILD for summary_op_benchmark_test
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 26, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 26, 2020
@annarev annarev added the kokoro:force-run Tests on submitted change label Aug 27, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 27, 2020
@tensorflow-copybara tensorflow-copybara merged commit c64796c into tensorflow:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annarev annarev annarev approved these changes

@bmzhao bmzhao bmzhao left review comments

Assignees
No one assigned
Labels
cla: yes ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dnguyen28061 @bmzhao @annarev @googlebot @kokoro-team @tensorflow-copybara @rthadur