Add complex data type support for tf.math.acos in XLA #41386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tries to address the issur raised in 41370 where tf.math.acos throws out error with complex input data. The issue was that in XLA the `Acos` op does not capture the complex data types. This PR adds complex support for tf.math.acos in XLA This PR fixes 41370. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
thomasjoerg
reviewed
Aug 4, 2020
| return b->ReportErrorOrReturn([&]() -> StatusOr<XlaOp> { | ||
| TF_ASSIGN_OR_RETURN(auto shape, b->GetShape(x)); | ||
|
|
||
| // complex: acos(x) = -i * log(x + sqrt(-(x+1)*(x-1))) |
There was a problem hiding this comment.
The code on line 1127 multiplies the sqrt by -i. The expression inside the sqrt is also a bit different.
Please eliminate the inconsistencies and move the comment up before the method.
…eview Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
|
Thanks @thomasjoerg for the review. The PR has been updated with code comment moved to the top and changed to match the implementation. Please take a look and let me know if there are any issues. |
thomasjoerg
approved these changes
Aug 7, 2020
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the issur raised in #41370
where tf.math.acos throws out error with complex input data.
The issue was that in XLA the
Acosop does not capturethe complex data types.
This PR adds complex support for tf.math.acos in XLA
This PR fixes #41370.
Signed-off-by: Yong Tang yong.tang.github@outlook.com