Use Bazel's builtin patch support. #41393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
force-pushed
the
builtin-patch
branch
2 times, most recently
from
7faf48b
to
766f4e1
Compare
|
We had issues in the past where patching wouldn't work on Windows/Linux. We have tried Adding gunan@ to verify if this is likely to solve all issues form above and if the diffs are also ok, as I was not expecting them to be generated given PR title/description |
|
I had to regenerate some of the patch files because the builtin patch is stricter than |
mihaimaruseac
previously approved these changes
Jul 16, 2020
google-ml-butler
bot
added
kokoro:force-run
This removes a dependency on the system having a patch executable.
|
As long as presubmits pass, I think we can accept this change. |
|
Only "Windows Bazel GPU " appears to have failed, but it also is broken on master. |
gunan
approved these changes
Jul 16, 2020
google-ml-butler
bot
added
kokoro:force-run
|
Will import this manually, something breaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a dependency on the system having a patch executable.